i have given the constraint but still its not working